This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable
- From: Andreas Schwab <schwab at suse dot de>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Markus Deuling <deuling at de dot ibm dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 21 Dec 2006 12:47:54 +0100
- Subject: Re: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable
- References: <458A3B6C.2040803@de.ibm.com> <20061221110904.GG3640@adacore.com>
Joel Brobecker <brobecker@adacore.com> writes:
>> ChangeLog:
>>
>> * server.c (handle_general_set): New variable len instead
>> of using strlen two times.
>
> Actually, since the same string is duplicated a couple of times,
> I would also suggest declaring a constant string "QPassSignals:"
> and use the constant instead of risking a typo... How about:
>
> const char str[] = "QPassSignals:";
Or just define it as a macro.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."