This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFA] Add support for catch Ada exceptions


> >     (gdb) catch exception
> >     Catchpoint 1 on all Ada exceptions at 0x804b7c0
> >     (gdb) info break
> >     Num Type           Disp Enb Address    What
> >     1   catch exception keep y   0x0804b7c0 on all Ada exceptions
> 
> I don't like this ``on'' business.  How about removing it?

Sure, that's a good idea.

> >     (gdb) catch exception unhandled
> >     Catchpoint 3 on unhandled Ada exceptions at 0x804ad2d
> 
> Again, removing the ``on'' part makes it sound better, IMO:
> 
>     (gdb) catch exception program_error
>     Catchpoint 1: `program_error' Ada exception at 0x804b7c0

Ditto.

> Btw, do we need to display the address?  The fact that you actually
> implement this as breakpoints is an implementation detail; the user
> doesn't need to know, I think.

You are right, displaying the addresses can be confusing.

I will resend a new patch shortly...  Thanks for the feedback!

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]