This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI failures related to string printing
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: nickrob at snap dot net dot nz
- Cc: ghost at cs dot msu dot su, gdb-patches at sources dot redhat dot com
- Date: Tue, 16 Jan 2007 22:23:06 +0100 (CET)
- Subject: Re: MI failures related to string printing
- References: <200701121351.29310.vladimir@codesourcery.com> <17831.31430.442855.801431@kahikatea.snap.net.nz> <E1H6dkH-0005Wy-Lu@zigzag.lvk.cs.msu.su> <17836.26533.146945.793792@kahikatea.snap.net.nz>
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Tue, 16 Jan 2007 18:50:29 +1300
>
> > Is there any chance you'll robustify the testsuite?
>
> If your just talking about the one FAIL in mi-var-child.exp, why not
> just mark it as an XFAIL? I see that the other XFAIL actually
> passes (for me, at least).
The very fact that we're even having this discussion means that you
did something wrong Nick; you either didn't check for regressions or
ignored them.
Turning a regression test from a PASS into a FAIL, means you've
changed behaviour. Now that change could be intentional, but then you
should have said so when you submitted the patch, and you should have
adjusted the test.
I'm still not convinced the change is ok. Having 'char *' point to a
buffer that's not null-terminated is not uncommon. We have a lot of
those in gdb itself.
Mark