This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register()
- From: Daniel Jacobowitz <drow at false dot org>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 18 Jan 2007 11:28:56 -0500
- Subject: Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register()
- References: <45AF6A01.1020605@de.ibm.com>
On Thu, Jan 18, 2007 at 01:37:21PM +0100, Markus Deuling wrote:
> Hi,
>
> ppc_cannot_store_register() from linux-ppc-low.c returns 2 instead of 1.
> This seems to be broken. In linux-low.c:usr_store_inferior_registers()
> there is following comparison:
>
> if ((*the_low_target.cannot_store_register) (regno) == 1)
> return;
>
> This won't work with ppc low target. The patch returns 1 instead of 2.
That's the whole point - the return value of two exists to avoid that
check.
Why did you want this patch, i.e. does it fix a problem you
encountered?
--
Daniel Jacobowitz
CodeSourcery