This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register()


On Thu, Jan 18, 2007 at 01:37:21PM +0100, Markus Deuling wrote:
> Hi,
> 
> ppc_cannot_store_register() from linux-ppc-low.c returns 2 instead of 1.
> This seems to be broken. In linux-low.c:usr_store_inferior_registers() 
> there is following comparison:
> 
>      if ((*the_low_target.cannot_store_register) (regno) == 1)
>        return;
> 
> This won't work with ppc low target. The patch returns 1 instead of 2.

That's the whole point - the return value of two exists to avoid that
check.

Why did you want this patch, i.e. does it fix a problem you
encountered?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]