This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [mi] fix 'editable' attribute for references


Daniel Jacobowitz wrote:

> On Tue, Jan 16, 2007 at 10:06:30PM +0300, Vladimir Prus wrote:
>> Vladimir Prus wrote:
>> 
>> > 
>> > I've noticed that the -var-show-references returns 'attr=noneditable'
>> > for structures, but 'attr=editable' for references to structures, which
>> > makes no sense.
>> 
>> I've also noticed that while for structures, we don't compare old
>> and new values, and never report varobj corresponding to structure as
>> changed, we do all that for references to structures. This patch fixes
>> both problems, OK?
> 
> This is included in the C++ references patch I just reviewed, right?

Grr, right. I meant to post them as completely separate patches to ease review,
but messed that up and you've reviewed combined patch.

My only excuse is that I'll still commit those as separate patches, so that
at least the history is right.

- Volodya



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]