This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Formatting changes to mi-main.c
On Sat, Feb 03, 2007 at 01:20:28PM +0100, Mark Kettenis wrote:
> The above comment is pointless anyway. And probably misleading,
> because the file probably needs gdbcore.h for things besides
> write_memory by now.
>
> I encourage people deleting similar comments, and we really shouln't
> add any new comments like that, until something very non-obvious is
> going on. In that case you'd probably need several sentences anyway
> to explain things.
Completely agreed. We have occasional non-obvious header includes
(e.g. ordering problems with system headers), but the rest of the time
it should be obvious: it's a GDB header, we want it for the GDB
functionality it contains, and if the file still compiles with it
removed that usually means we don't need it any more :-)
--
Daniel Jacobowitz
CodeSourcery