This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ob] Fix mingw build
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 6 Feb 2007 10:32:48 +1300
- Subject: Re: [ob] Fix mingw build
- References: <20070205132346.GA28998@nevyn.them.org>
> Our autotester broke after Nick's timings patch; we have a forward
> declaration of struct timeval, but not a full definition. This fixes
> it. We already include <sys/time.h> unconditionally in a number of
> other places.
I don't quite understand why it failed as the timeval members are only
accessed in mi-main.c which already included sys/time.h (for mi_load_progress).
> Index: mi/mi-parse.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/mi/mi-parse.h,v
> retrieving revision 1.7
> diff -u -p -r1.7 mi-parse.h
> --- mi/mi-parse.h 2 Feb 2007 23:01:27 -0000 1.7
> +++ mi/mi-parse.h 5 Feb 2007 13:20:56 -0000
> @@ -22,6 +22,8 @@
> #ifndef MI_PARSE_H
> #define MI_PARSE_H
>
> +#include <sys/time.h>
> +
> /* MI parser */
>
> /* Timestamps for current command and last asynchronous command. */
It's best here anyway. Although it doesn't break anything, maybe it should be
removed from mi-main.c now.
--
Nick http://www.inet.net.nz/~nickrob