Re: [RFC] Patch to add kernel threads support for FreeBSD 6.1

[Fred Fish <fnf at specifix dot com>]

On Thursday 08 February 2007 14:47, Mark Kettenis wrote:
> Can you avoid introducing supply_xxregset()/fill_xxregset() and use
> register sets instead?

OK.

> Is the child_suppress_run hack really necessary?  I thought the right
> stratum was automatically chosen.

It was introduced to work around the issue that you can't have two
targets ready to run at the same time, apparently.  That's an area
I'm not intimately familar with.  I believe the patch originated in
some BSD code.

> > +#define GET_PID(ptid)		ptid_get_pid (ptid)
> > +#define GET_LWP(ptid)		ptid_get_lwp (ptid)
> > +#define GET_THREAD(ptid)	ptid_get_tid (ptid)
> > +
> > +#define IS_LWP(ptid)		(GET_LWP (ptid) != 0)
> > +#define IS_THREAD(ptid)		(GET_THREAD (ptid) != 0)
> > +
> > +#define BUILD_LWP(lwp, pid)	ptid_build (pid, lwp, 0)
> > +#define BUILD_THREAD(tid, pid)	ptid_build (pid, 0, tid)
> 
> These days these macros are really pointless and I think they should
> die (here and elsewhere in the code).

Fine by me.  :-)

Of course this is somewhat of a moot point if the fact that the main
support file comes directly from FreeBSD prevents this patch from
going into mainline gdb.

-Fred