This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Set pascal language for DWarf debug information


I committed the patch.

I also added a reference to the bug in the database as
 Fix PR pascal/2223.

From looking into older ChangeLog's I assumed that
that the bug category should be used for the first part.

Concerning the testsuite, it would be nice indeed to have at least some tests
but the problem is that I don't know anything about the tests,
and when I tried to run the tests on my cygwin cvs,
it did nothing... I tried to checkout the dejagnu directory,
but it seems to be almost empty.


 Is it possible to use the testsuite on Cygwin, and how do I
enable it?

Pierre Muller

----- Original Message ----- From: "Daniel Jacobowitz" <drow@false.org>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>; <ezannoni@redhat.com>
Sent: Thursday, February 08, 2007 7:02 PM
Subject: Re: [RFA] Set pascal language for DWarf debug information



On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote:
I extended his proposed patch to dwarfread.c file also.

Might as well - but we will be deleting that file very shortly.


 I can see no risks associated with the given patch,
and I hope that, despite the long time since my last
RFA, it is formatted correctly.
 It is in a way, pascal specific, but as it is
not in a pascal only file, I prefer to get approval
before committing.

Thanks. The patch is OK, with an adjusted ChangeLog entry:


2007-02-05 Pierre Muller <muller@ics.u-strasbg.fr>

        * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as
pascal language marker.
        * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83
as pascal language marker.

* dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as Pascal language marker. * dwarf2read.c (set_cu_language): Likewise.

(wrap at a reasonable width, leave off "gdb/" prefix because the entry
goes in gdb/ChangeLog).

Pierre, is there any way we can get some Pascal tests into the
testsuite?  I can find a working compiler to test with if we had some
tests.


-- Daniel Jacobowitz CodeSourcery





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]