This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "target remote | " stderr
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 17 Feb 2007 12:56:08 +0200
- Subject: Re: "target remote | " stderr
- References: <200701261653.53834.vladimir@codesourcery.com> <20070126140028.GA29456@nevyn.them.org> <epq9dd$k4s$1@sea.gmane.org> <20070131144101.GA23780@nevyn.them.org> <eqnhq8$8nt$1@sea.gmane.org> <uire85tq7.fsf@gnu.org> <E1HIK6J-000273-D7@zigzag.lvk.cs.msu.su>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Sat, 17 Feb 2007 10:34:36 +0300
>
> >> + int error_fd; /* File descriptor for a separate
> >> + error stream that should be
> >> + immediately forwarded to gdb_stderr.
> >> + This may be -1.
> >> + If != -1, this descriptor should
> >> + be non-blocking. */
> >
> > This comment isn't according to GNU coding standards, I think.
>
> Can you please be more specific?
Not sure what you want me to say. Multiline, multiple-sentence
comments should not be alongside of the code, they should precede the
code. Example:
/* File descriptor for a separate error stream that should be
immediately forwarded to gdb_stderr. This may be -1.
If != -1, this descriptor should be non-blocking. */
int error_fd;
> >> +#ifdef _WIN32
> >
> > Won't this catch Cygwin as well? Do we want that?
>
> I would hope this won't catch cygwin, but I don't know. I'll check.
Thanks.