This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdbserver: should use __ARCH_HAS_MMU__ rather than __UCLIBC_HAS_MMU__
- From: Michael Snyder <Michael dot Snyder at palmsource dot com>
- To: Jon Ringle <jon at ringle dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 07 Mar 2007 11:04:37 -0800
- Subject: Re: gdbserver: should use __ARCH_HAS_MMU__ rather than __UCLIBC_HAS_MMU__
- References: <45EE3DD7.80302@ringle.org>
On Tue, 2007-03-06 at 23:21 -0500, Jon Ringle wrote:
> Please see: http://sourceware.org/ml/gdb/2007-03/msg00099.html
>
> Jon
>
> plain text document attachment (gdbserver-ARCH_HAS_MMU.patch)
> Index: linux-low.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
> retrieving revision 1.53
> diff -u -r1.53 linux-low.c
> --- linux-low.c 26 Feb 2007 20:10:18 -0000 1.53
> +++ linux-low.c 7 Mar 2007 04:14:22 -0000
> @@ -42,6 +42,12 @@
> # define PTRACE_SETSIGINFO 0x4203
> #endif
>
> +#ifdef __UCLIBC__
> +#if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
> +#define HAS_NOMMU
> +#endif
> +#endif
Shouldn't it be !defined(__ARCH_HAS_MMU__)?
And please remove the change below -- I'm sure it has
nothing to do with the one above.
> Index: server.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
> retrieving revision 1.48
> diff -u -r1.48 server.c
> --- server.c 26 Feb 2007 20:10:18 -0000 1.48
> +++ server.c 7 Mar 2007 04:14:23 -0000
> @@ -255,7 +255,7 @@
> {
> static struct inferior_list_entry *thread_ptr;
>
> - if (strcmp ("qSymbol::", own_buf) == 0)
> + if (strcmp ("qSymbol:", own_buf) == 0)
> {
> if (the_target->look_up_symbols != NULL)
> (*the_target->look_up_symbols) ();