This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Improve end check on rs6000 prologue analyzer
On Mon, Mar 12, 2007 at 10:02:08PM +0100, Mark Kettenis wrote:
> Ah, I think I've seen this before. On OpenBSD the tty subsystem does
> tab expansion, wheras on Linux this doesn't happen by default. So we
> must match spaces as well as tabs here. I think that means the second
> pattern is really redundant. How about the attached patch?
Yeesh! I didn't know that. Is there somewhere we could write it down
for test writers who make this same mistake, maybe? I would have
merrily written tests that expected the tab :-(
Your patch looks right to me. I know that I hit the "step over
initial brace" on all platforms on a regular basis - it's not like
this is a new problem. But letting it pass is probably relatively
newer than the IRIX-specific xfail.
--
Daniel Jacobowitz
CodeSourcery