This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: TUI + gdbserver broken?
On Tue, Mar 20, 2007 at 12:38:46AM +0000, Pedro Alves wrote:
> How about the attached? Move the selected_frame creation logic
> to select_frame.
> It fixes both the remote debugging problem, and the repainting
> problems - probably caused by the get_selected_frame calling
> select_frame generating extra spurious events.
> It would need a testsuite run and a bit of cleanup, since the
> get_selected_frame would lose the parameter.
Please don't. The comment you're deleting in get_selected_frame is
very important:
- /* There is always a frame. */
Andrew went to a lot of work making this true, and we now assume it
all over the place. Every caller of get_selected_frame now assumes it
returns a valid frame.
If you're stuck tracking down what TUI is doing on Cygwin, I will
compare this with Denis's findings and see what happens on Linux.
--
Daniel Jacobowitz
CodeSourcery