This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove DEPRECATED_REMOTE_BREAKPOINT
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Mar 2007 12:27:26 -0400
- Subject: Re: [rfc] Remove DEPRECATED_REMOTE_BREAKPOINT
- References: <200702280207.l1S278BE026425@d12av02.megacenter.de.ibm.com>
On Wed, Feb 28, 2007 at 03:07:08AM +0100, Ulrich Weigand wrote:
> Hello,
>
> this patch removes DEPRECATED_REMOTE_BREAKPOINT and its big/little endian
> variants. The macro is used if you need to use a different byte pattern
> as breakpoint when using the remote target (as compared to the native target).
> The only remaining user is tm-sh.h.
>
> To remove the macro without changing the behaviour on SH, I've added a
> check to sh_breakpoint_from_pc whether target_shortname is "remote",
> and return the remote-specific breakpoint sequence in that case.
>
> This is a bit weird, but there's some precedent for this method in
> mips_breakpoint_from_pc, which also returns different byte patterns
> depending on the value of target_shortname.
>
> Tested by building a sh-netbsd cross-GDB.
>
> I'd appreciate any feedback on this method -- did I overlook something
> easier/better?
Looks fine to me. I don't know if the current behavior is even
necessary, but I don't have enough SH targets to test it with any
confidence.
--
Daniel Jacobowitz
CodeSourcery