This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Remove old WinCE support.


Hi all,

Here is the patch that removes the old WinCE support that was based
on the wince.c/wince-stub.c files.  These files implemented their own
remote protocol.  They are deprecated, and scheduled for removal
for this month.  The old support supported ARM, SH and MIPS.  I've
checked in the new support for ARM based on gdbserver,
so if there is interest in those architectures, there is now a
solid starting point there.  I'd be surprised to hear that there
are still WinCE users of SH or MIPS around here in a near future.
I wouldn't be surprised to hear that SH and MIPS WinCE binutils/gcc are
broken due to bitrotting.

As far as I can see, mips_next_pc was only exported for wince.c to
use, so we can now make it static.  Same for arm_get_next_pc, but
while I was at it, I made arm_pc_is_thumb and thumb_get_next_pc
static too.  arm_pc_is_thumb_dummy is no longer defined anywhere,
so its declaration can be removed.

The rest of the patch removes unneeded tm and mt files, and
the wince.c and wince-stub.[c|h] files.

Note: Completely untested.  Too late for that today - will try tomorrow,
but it should be pretty obvious.

Eli, the documentation this patch removes is the same you saw in the
WinCE gdbserver patch.  I didn't commit it, since it is documenting
features implemented in wince.c, which I was going to remove then, but
ended up postponing to this patch.

Cheers,
Pedro Alves



gdb/

2007-03-29  Pedro Alves  <pedro_alves@portugalmail.pt>

	* Makefile.in (wince.o): Remove rule.
	(wince-stub.o): Likewise.
	* mips-tdep.c (mips_next_pc): Make static.
	* mips-tdep.h (mips_next_pc): Remove declaration.
	* configure.tgt (mips*-*-pe): Remove.
	(sh*-*-pe): Remove.
	* arm-tdep.c (arm_pc_is_thumb): Make static.
	(thumb_get_next_pc): Likewise.
	(arm_get_next_pc): Likewise.
	* arm-tdep.h (arm_pc_is_thumb_dummy): Remove declaration.
	(arm_pc_is_thumb): Likewise.
	(thumb_get_next_pc): Likewise.
	(arm_get_next_pc): Likewise.
	* config/sh/tm-wince.h: Remove.
	* config/sh/wince.mt: Remove.
	* config/mips/tm-wince.h: Remove.
	* config/mips/wince.mt: Remove.
	* wince.c: Remove.
	* wince-stub.c: Remove.
	* wince-stub.h: Remove.

gdb/doc/

2007-03-29  Pedro Alves  <pedro_alves@portugalmail.pt>

	* gdb.texinfo (WinCE): Delete subsection.

---
 gdb/Makefile.in     |    6 ------
 gdb/arm-tdep.c      |    6 +++---
 gdb/arm-tdep.h      |    9 ---------
 gdb/configure.tgt   |    2 --
 gdb/doc/gdb.texinfo |   39 ---------------------------------------
 gdb/mips-tdep.c     |    2 +-
 gdb/mips-tdep.h     |    3 ---
 7 files changed, 4 insertions(+), 63 deletions(-)

Index: src/gdb/Makefile.in
===================================================================
--- src.orig/gdb/Makefile.in	2007-03-29 02:48:32.000000000 +0100
+++ src/gdb/Makefile.in	2007-03-29 02:49:36.000000000 +0100
@@ -836,7 +836,6 @@ varobj_h = varobj.h $(symtab_h) $(gdbtyp
 vax_tdep_h = vax-tdep.h
 vec_h = vec.h $(gdb_assert_h) $(gdb_string_h)
 version_h = version.h
-wince_stub_h = wince-stub.h
 wrapper_h = wrapper.h $(gdb_h)
 xcoffsolib_h = xcoffsolib.h
 xml_support_h = xml-support.h $(gdb_obstack_h) $(vec_h)
@@ -2896,11 +2895,6 @@ win32-nat.o: win32-nat.c $(defs_h) $(fra
 	$(regcache_h) $(top_h) $(buildsym_h) $(symfile_h) $(objfiles_h) \
 	$(gdb_string_h) $(gdbthread_h) $(gdbcmd_h) $(exec_h) $(solist_h) \
 	$(solib_h) $(i386_tdep_h) $(i387_tdep_h)
-wince.o: wince.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
-	$(exceptions_h) $(gdbcore_h) $(command_h) $(buildsym_h) $(symfile_h) \
-	$(objfiles_h) $(gdb_string_h) $(gdbthread_h) $(gdbcmd_h) \
-	$(wince_stub_h) $(regcache_h) $(mips_tdep_h)
-wince-stub.o: wince-stub.c $(wince_stub_h)
 wrapper.o: wrapper.c $(defs_h) $(value_h) $(exceptions_h) $(wrapper_h) \
 	$(ui_out_h)
 xcoffread.o: xcoffread.c $(defs_h) $(bfd_h) $(gdb_string_h) $(gdb_stat_h) \
Index: src/gdb/mips-tdep.c
===================================================================
--- src.orig/gdb/mips-tdep.c	2007-03-29 02:48:32.000000000 +0100
+++ src/gdb/mips-tdep.c	2007-03-29 02:49:36.000000000 +0100
@@ -1352,7 +1352,7 @@ mips16_next_pc (CORE_ADDR pc)
    It works by decoding the current instruction and predicting where a
    branch will go. This isnt hard because all the data is available.
    The MIPS32 and MIPS16 variants are quite different */
-CORE_ADDR
+static CORE_ADDR
 mips_next_pc (CORE_ADDR pc)
 {
   if (pc & 0x01)
Index: src/gdb/mips-tdep.h
===================================================================
--- src.orig/gdb/mips-tdep.h	2007-03-29 02:48:32.000000000 +0100
+++ src/gdb/mips-tdep.h	2007-03-29 02:49:36.000000000 +0100
@@ -40,9 +40,6 @@ enum mips_abi
 /* Return the MIPS ABI associated with GDBARCH.  */
 enum mips_abi mips_abi (struct gdbarch *gdbarch);
 
-/* For wince :-(.  */
-extern CORE_ADDR mips_next_pc (CORE_ADDR pc);
-
 /* Return the MIPS ISA's register size.  Just a short cut to the BFD
    architecture's word size.  */
 extern int mips_isa_regsize (struct gdbarch *gdbarch);
Index: src/gdb/configure.tgt
===================================================================
--- src.orig/gdb/configure.tgt	2007-03-29 02:49:00.000000000 +0100
+++ src/gdb/configure.tgt	2007-03-29 02:49:36.000000000 +0100
@@ -146,7 +146,6 @@ m88*-*-openbsd*)	gdb_target=obsd ;;
 
 mep-*-*)		gdb_target=mep ;;
 
-mips*-*-pe)		gdb_target=wince ;;
 mips*-sgi-irix5*)	gdb_target=irix5 ;;
 mips*-sgi-irix6*)	gdb_target=irix6 ;;
 mips*-*-linux*)		gdb_target=linux
@@ -186,7 +185,6 @@ s390*-*-*)		gdb_target=s390
 			;;
 
 score-*-*)		gdb_target=embed ;;
-sh*-*-pe)		gdb_target=wince ;;
 sh-*-coff*)		gdb_target=embed ;;
 sh-*-elf*)		gdb_target=embed ;;
 # FIXME should that be sh*-*-linux*, perhaps?
Index: src/gdb/arm-tdep.c
===================================================================
--- src.orig/gdb/arm-tdep.c	2007-03-29 03:06:58.000000000 +0100
+++ src/gdb/arm-tdep.c	2007-03-29 03:07:10.000000000 +0100
@@ -217,7 +217,7 @@ int arm_apcs_32 = 1;
 /* Determine if the program counter specified in MEMADDR is in a Thumb
    function.  */
 
-int
+static int
 arm_pc_is_thumb (CORE_ADDR memaddr)
 {
   struct minimal_symbol *sym;
@@ -1603,7 +1603,7 @@ bitcount (unsigned long val)
   return nbits;
 }
 
-CORE_ADDR
+static CORE_ADDR
 thumb_get_next_pc (CORE_ADDR pc)
 {
   unsigned long pc_val = ((unsigned long) pc) + 4;	/* PC after prefetch */
@@ -1659,7 +1659,7 @@ thumb_get_next_pc (CORE_ADDR pc)
   return nextpc;
 }
 
-CORE_ADDR
+static CORE_ADDR
 arm_get_next_pc (CORE_ADDR pc)
 {
   unsigned long pc_val;
Index: src/gdb/arm-tdep.h
===================================================================
--- src.orig/gdb/arm-tdep.h	2007-03-03 17:47:44.000000000 +0000
+++ src/gdb/arm-tdep.h	2007-03-29 03:05:26.000000000 +0100
@@ -187,15 +187,6 @@ struct gdbarch_tdep
 #define LOWEST_PC (gdbarch_tdep (current_gdbarch)->lowest_pc)
 #endif
 
-/* Prototypes for internal interfaces needed by more than one MD file.  */
-int arm_pc_is_thumb_dummy (CORE_ADDR);
-
-int arm_pc_is_thumb (CORE_ADDR);
-
-CORE_ADDR thumb_get_next_pc (CORE_ADDR);
-
-CORE_ADDR arm_get_next_pc (CORE_ADDR);
-
 /* Functions exported from armbsd-tdep.h.  */
 
 /* Return the appropriate register set for the core section identified
Index: src/gdb/doc/gdb.texinfo
===================================================================
--- src.orig/gdb/doc/gdb.texinfo	2007-03-29 02:11:18.000000000 +0100
+++ src/gdb/doc/gdb.texinfo	2007-03-29 03:18:26.000000000 +0100
@@ -14299,7 +14299,6 @@ acceptable commands.
 * AVR::                         Atmel AVR
 * CRIS::                        CRIS
 * Super-H::                     Renesas Super-H
-* WinCE::                       Windows CE child processes
 @end menu
 
 @node ARM
@@ -15488,44 +15487,6 @@ commands:
 Show the values of all Super-H registers.
 @end table
 
-@node WinCE
-@subsection Windows CE
-@cindex Windows CE
-
-The following commands are available for Windows CE:
-
-@table @code
-@item set remotedirectory @var{dir}
-@kindex set remotedirectory
-Tell @value{GDBN} to upload files from the named directory @var{dir}.
-The default is @file{/gdb}, i.e.@: the root directory on the current
-drive.
-
-@item show remotedirectory
-@kindex show remotedirectory
-Show the current value of the upload directory.
-
-@item set remoteupload @var{method}
-@kindex set remoteupload
-Set the method used to upload files to remote device.  Valid values
-for @var{method} are @samp{always}, @samp{newer}, and @samp{never}.
-The default is @samp{newer}.
-
-@item show remoteupload
-@kindex show remoteupload
-Show the current setting of the upload method.
-
-@item set remoteaddhost
-@kindex set remoteaddhost
-Tell @value{GDBN} whether to add this host to the remote stub's
-arguments when you debug over a network.
-
-@item show remoteaddhost
-@kindex show remoteaddhost
-Show whether to add this host to remote stub's arguments when
-debugging over a network.
-@end table
-
 
 @node Architectures
 @section Architectures




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]