This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "target remote | " stderr -- try2
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: ghost at cs dot msu dot su
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 6 Apr 2007 10:24:08 +0200 (CEST)
- Subject: Re: "target remote | " stderr -- try2
- References: <200703251735.13369.vladimir@codesourcery.com> <20070329180627.GD28418@caradoc.them.org> <ev4o2p$v2n$1@sea.gmane.org>
> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Fri, 06 Apr 2007 10:06:24 +0400
>
> Daniel Jacobowitz wrote:
>
> > On Sun, Mar 25, 2007 at 04:35:13PM +0300, Vladimir Prus wrote:
> >>
> >> This is a revision of my earlier patch to make
> >> stderr output from program run with
> >>
> >> target remote | some_program
> >>
> >> to be routed through gdb_stderr, so that MI
> >> frontend sees that output.
> >>
> >> The original patch is at:
> >>
> >> http://thread.gmane.org/gmane.comp.gdb.patches/32540
> >>
> >> and this version differs by not having any #ifdef WIN32 inside
> >> ser-base.c, but instead using new method in 'struct serial_ops',
> >> that is initialized in ser-mingw.c.
> >>
> >> OK?
> >
> > This version is OK. Thanks!
>
> Doh! It turns out I've attached a patch that won't even compile.
> Although the difference to the real patch is trivial, for avoidance
> of doubt I attach the "right" patch and the delta to the previous
> one. Is this version OK?
I like this version a lot better than the one with #ifdef WIN32.
Thanks Volodya, for taking the trouble to clean things up.
Mark