This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Disable 3 testcases for gdbserver
- From: Daniel Jacobowitz <drow at false dot org>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Sun, 29 Apr 2007 11:49:57 -0400
- Subject: Re: [rfc] Disable 3 testcases for gdbserver
- References: <4631D8BB.1000909@de.ibm.com>
On Fri, Apr 27, 2007 at 01:04:27PM +0200, Markus Deuling wrote:
> Hi,
>
> this patch marks 3 testcases as unsupported for running with gdbserver.
>
> Testcase auxv.exp wants to create a core file, multi-forks.exp uses follow-fork
> and checkpoints.exp is using checkpoints :-)
>
> All features aren't (yet) implemented in gdbserver.
>
> Is this ok?
Almost. Half of auxv.exp can run without a core file, and that half
should be tested using gdbserver, since gdbserver implements auxv
support.
I've checked in this version, which uses the same idiom used in a
number of other files. Thanks!
--
Daniel Jacobowitz
CodeSourcery
2007-04-29 Markus Deuling <deuling@de.ibm.com>
Daniel Jacobowitz <dan@codesourcery.com>
* gdb.base/auxv.exp (core_works): Also check is_remote.
* gdb.base/checkpoint.exp, gdb.base/multi-forks.exp: Likewise.
Index: gdb.base/auxv.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/auxv.exp,v
retrieving revision 1.7
diff -u -p -r1.7 auxv.exp
--- gdb.base/auxv.exp 9 Jan 2007 17:59:09 -0000 1.7
+++ gdb.base/auxv.exp 29 Apr 2007 15:46:39 -0000
@@ -50,7 +50,7 @@ if { [gdb_compile "${srcdir}/${subdir}/
# Make it the working directory for gdb and its child.
set coredir "${objdir}/${subdir}/coredir.[getpid]"
file mkdir $coredir
-set core_works [isnative]
+set core_works [expr [isnative] && ! [is_remote target]]
# Run GDB on the test program up to where it will dump core.
Index: gdb.base/checkpoint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/checkpoint.exp,v
retrieving revision 1.5
diff -u -p -r1.5 checkpoint.exp
--- gdb.base/checkpoint.exp 9 Mar 2007 15:20:16 -0000 1.5
+++ gdb.base/checkpoint.exp 29 Apr 2007 15:46:39 -0000
@@ -21,7 +21,7 @@ if $tracelevel then {
strace $tracelevel
}
-if { ![isnative] } then {
+if { [is_remote target] || ![isnative] } then {
continue
}
Index: gdb.base/multi-forks.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/multi-forks.exp,v
retrieving revision 1.9
diff -u -p -r1.9 multi-forks.exp
--- gdb.base/multi-forks.exp 26 Jan 2007 14:53:10 -0000 1.9
+++ gdb.base/multi-forks.exp 29 Apr 2007 15:46:39 -0000
@@ -18,7 +18,7 @@ if $tracelevel then {
strace $tracelevel
}
-if { ![isnative] } then {
+if { [is_remote target] || ![isnative] } then {
continue
}