Re: [patch] Single stepping over atomic instruction sets for GDB 6.6

[Luis Machado <luisgpm at linux dot vnet dot ibm dot com>]

Thanks Jan,

I think your patch could be applied on top of the first piece of the
single stepping patch, the one that actually changed code on infrun.c.
It's already in HEAD.

http://sourceware.org/ml/gdb-cvs/2007-04/msg00043.html

Regards,
Luis


On Sun, 2007-04-29 at 09:07 +0200, Jan Kratochvil wrote:
> On Sun, 29 Apr 2007 01:35:41 +0200, Luis Machado wrote:
> ...
> > I'd like to better understand your patch. So please, if you could go
> > through the modifications, that would be nice.
> 
> Your patch sets SINGLESTEP_BREAKPOINTS_INSERTED_P conditionally, according to
> whether SOFTWARE_SINGLE_STEP () was successful.
> SINGLESTEP_BREAKPOINTS_INSERTED_P was always set before so the original GDB
> code does not expect it can be unset.
> 
> I have updated the code to handle the case when SOFTWARE_SINGLE_STEP () failed
> (and so SINGLESTEP_BREAKPOINTS_INSERTED_P is unset; it could safely fail to
> software singlestep because hardware singlestepping feature is available).
> 
> 
> Regards,
> Jan