This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: uweigand at de dot ibm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 1 May 2007 22:39:34 +0200 (CEST)
- Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
- References: <200705010126.l411Q814016557@d12av02.megacenter.de.ibm.com>
> Date: Tue, 1 May 2007 03:26:04 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> I'd appreciate any feedback! Do you think this would be OK to commit?
Some general notes:
1. core_fns/core_read_registers should really die (it'd already
deprecated) and replaced by gdbarch_regset_from_core_section().
2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset
should really be replaced by something like
gdbarch_regset_from_core_section().
That said, this diff is great progress, and I think it should go in
ASAP. It's probably polite to give other responsable maintainers the
opportunity to react to the diff. So consider this an explicit ok for
the i387 targets.
Mark