This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove mips/tm-linux.h
On Wed, May 02, 2007 at 01:07:43AM +0200, Ulrich Weigand wrote:
> Then mips gdbarch could override that method, and call the
> standard in_solib_dynsym_resolve_code plus its own special
> check for dynamic stubs.
Right - that would work too. I'll skip it for now, though, since
there's only one place that needed it.
> > Tested on mips64-linux, all three ABIs, no change in results.
>
> I'm wondering why you didn't run into this #error in gdbarch.h:
>
> #if !defined (GDB_TM_FILE) && defined (CANNOT_FETCH_REGISTER)
> #error "Non multi-arch definition of CANNOT_FETCH_REGISTER"
> #endif
>
> #if !defined (GDB_TM_FILE) && defined (CANNOT_STORE_REGISTER)
> #error "Non multi-arch definition of CANNOT_STORE_REGISTER"
> #endif
>
> because the mips-linux NM file still defines those two macros,
> and you just removed the TM file ...
>
> I did run into the that problem on ia64. That's the reason
> why I was recently trying to remove the mips-linux NM file,
> before going after the TM -- but that still isn't quite
> resolved.
Thank you! I hadn't noticed, because I don't generally build native
mips64-linux debuggers; it was a cross. I'll be sure not to commit
this until we resolve that.
--
Daniel Jacobowitz
CodeSourcery