This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Remove obsolete comments mentioning "read_register"
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 13 May 2007 14:49:48 +0200 (CEST)
- Subject: [commit] Remove obsolete comments mentioning "read_register"
Hello,
this removes a number of obsolete comments that mention "read_register".
The main benefit of this is to remove false hits when grepping for
read_register ...
Committed to mainline.
Bye,
Ulrich
ChangeLog:
* blockframe.c: Remove obsolete comments.
* alpha-nat.c (fetch_osf_core_registers): Update comment.
* arm-tdep.h (enum gdb_regnum): Remove obsolete part of comment.
* hppa-tdep.h (enum hppa_regnum): Likewise.
* mips-tdep.h: Likewise.
* m68hc11-tdep.c: Likewise.
diff -urNp gdb-orig/gdb/alpha-nat.c gdb-head/gdb/alpha-nat.c
--- gdb-orig/gdb/alpha-nat.c 2007-05-04 22:25:18.763141315 +0200
+++ gdb-head/gdb/alpha-nat.c 2007-05-04 22:26:49.978809997 +0200
@@ -34,7 +34,7 @@
/* Extract the register values out of the core file and store
- them where `read_register' will find them.
+ them into REGCACHE.
CORE_REG_SECT points to the register values themselves, read into memory.
CORE_REG_SIZE is the size of that area.
diff -urNp gdb-orig/gdb/arm-tdep.h gdb-head/gdb/arm-tdep.h
--- gdb-orig/gdb/arm-tdep.h 2007-04-13 02:22:43.000000000 +0200
+++ gdb-head/gdb/arm-tdep.h 2007-05-04 22:25:54.111360020 +0200
@@ -25,12 +25,7 @@
struct gdbarch;
struct regset;
-/* Register numbers of various important registers. Note that some of
- these values are "real" register numbers, and correspond to the
- general registers of the machine, and some are "phony" register
- numbers which are too large to be actual register numbers as far as
- the user is concerned but do serve to get the desired values when
- passed to read_register. */
+/* Register numbers of various important registers. */
enum gdb_regnum {
ARM_A1_REGNUM = 0, /* first integer-like argument */
diff -urNp gdb-orig/gdb/blockframe.c gdb-head/gdb/blockframe.c
--- gdb-orig/gdb/blockframe.c 2007-05-04 22:25:18.810134535 +0200
+++ gdb-head/gdb/blockframe.c 2007-05-04 22:26:50.026803073 +0200
@@ -28,9 +28,9 @@
#include "objfiles.h"
#include "frame.h"
#include "gdbcore.h"
-#include "value.h" /* for read_register */
-#include "target.h" /* for target_has_stack */
-#include "inferior.h" /* for read_pc */
+#include "value.h"
+#include "target.h"
+#include "inferior.h"
#include "annotate.h"
#include "regcache.h"
#include "gdb_assert.h"
diff -urNp gdb-orig/gdb/hppa-tdep.h gdb-head/gdb/hppa-tdep.h
--- gdb-orig/gdb/hppa-tdep.h 2007-05-03 02:05:12.000000000 +0200
+++ gdb-head/gdb/hppa-tdep.h 2007-05-04 22:26:05.238483526 +0200
@@ -26,12 +26,7 @@ struct trad_frame_saved_reg;
struct objfile;
struct so_list;
-/* Register numbers of various important registers.
- Note that some of these values are "real" register numbers,
- and correspond to the general registers of the machine,
- and some are "phony" register numbers which are too large
- to be actual register numbers as far as the user is concerned
- but do serve to get the desired values when passed to read_register. */
+/* Register numbers of various important registers. */
enum hppa_regnum
{
diff -urNp gdb-orig/gdb/m68hc11-tdep.c gdb-head/gdb/m68hc11-tdep.c
--- gdb-orig/gdb/m68hc11-tdep.c 2007-05-04 22:25:18.816133669 +0200
+++ gdb-head/gdb/m68hc11-tdep.c 2007-05-04 22:26:50.032802208 +0200
@@ -81,12 +81,7 @@ enum insn_return_kind {
};
-/* Register numbers of various important registers.
- Note that some of these values are "real" register numbers,
- and correspond to the general registers of the machine,
- and some are "phony" register numbers which are too large
- to be actual register numbers as far as the user is concerned
- but do serve to get the desired values when passed to read_register. */
+/* Register numbers of various important registers. */
#define HARD_X_REGNUM 0
#define HARD_D_REGNUM 1
diff -urNp gdb-orig/gdb/mips-tdep.h gdb-head/gdb/mips-tdep.h
--- gdb-orig/gdb/mips-tdep.h 2007-05-03 01:42:15.000000000 +0200
+++ gdb-head/gdb/mips-tdep.h 2007-05-04 22:26:19.303582314 +0200
@@ -58,12 +58,7 @@ struct mips_regnum
};
extern const struct mips_regnum *mips_regnum (struct gdbarch *gdbarch);
-/* Register numbers of various important registers. Note that some of
- these values are "real" register numbers, and correspond to the
- general registers of the machine, and some are "phony" register
- numbers which are too large to be actual register numbers as far as
- the user is concerned but do serve to get the desired values when
- passed to read_register. */
+/* Register numbers of various important registers. */
enum
{
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com