This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc][5/13] Eliminate read_register: read_register in sh_show_regs_command

On Thu, Jun 07, 2007 at 10:58:51PM +0200, Ulrich Weigand wrote:
> Hello,
> 
> this eliminates the single most numerous user of read_register, the
> sh_show_regs_command routine and its subroutines.  The patch adds a
> FRAME parameter to the sh_show_regs implementations, and passes in
> the current frame.  (Maybe it should really pass in the *selected*
> frame, in case the user issues the "regs" command from some other
> frame but the top?  That would be easy to change now.)

Using the selected frame makes sense to me too.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]