This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [2/10] Remove &builtin_type_ from tdep code (amd64/s390/sparc64)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: drow at false dot org (Daniel Jacobowitz)
- Cc: vladimir at codesourcery dot com (Vladimir Prus), gdb-patches at sourceware dot org
- Date: Wed, 13 Jun 2007 15:56:53 +0200 (CEST)
- Subject: Re: [2/10] Remove &builtin_type_ from tdep code (amd64/s390/sparc64)
Daniel Jacobowitz wrote:
> On Wed, Jun 13, 2007 at 03:17:09PM +0200, Ulrich Weigand wrote:
> > Daniel Jacobowitz wrote:
> > > On Wed, Jun 13, 2007 at 03:06:11PM +0200, Ulrich Weigand wrote:
> > > > However, this macro is not fully equivalent; in particular it
> > > > is no longer possible to use &builtin_type_double.
> > >
> > > You keep saying this, but is it true? :-)
> >
> > Well, you can take the address, but you won't get the gdbarch-swap
> > effect any more. So if you were relying on that, it'll break ...
>
> Right. Fortunately here we don't need the swap effect, since we have
> the right gdbarch - but I'd forgotten about post_init.
Also, in nearly all the cases an address of a builtin_type_ was taken,
it was in the context of a static initialization expression -- and
*there*, the macro would indeed be an error, as it no longer
represents a constant expression.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com