This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [OB] pointer ref, m2-typeprint.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Michael Snyder <msnyder at sonic dot net>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 1 Jul 2007 11:33:09 -0400
- Subject: Re: [OB] pointer ref, m2-typeprint.c
- References: <5515.12.7.175.2.1183077423.squirrel@webmail.sonic.net> <20070629004328.GA18113@caradoc.them.org> <9780.12.7.175.2.1183078961.squirrel@webmail.sonic.net> <20070629113703.GB13561@caradoc.them.org> <000f01c7ba7b$f2e3af20$677ba8c0@sonic.net>
On Fri, Jun 29, 2007 at 11:33:08AM -0700, Michael Snyder wrote:
> I agree. It would be pretty simple to make CHECK_TYPEDEF safe,
> and I think I would rather do that than go hunt down every place that
> calls it. What do you think? Should I add that to this patch?
>
> It would add a "not equal to null" test to every call to CHECK_TYPEDEF,
> of which there are many, but on today's hardware the cost should be less
> than negligable...
Do you think the case of a NULL type is at all common? I bet
everything that uses CHECK_TYPEDEF then looks inside the type, so if
we want null type checks, they'd be more useful before the
CHECK_TYPEDEF than inside it.
--
Daniel Jacobowitz
CodeSourcery