Re: [rfc] DLL support for gdbserver

[Pedro Alves <pedro_alves at portugalmail dot pt>]

Pedro Alves wrote:
> Daniel Jacobowitz wrote:
> > Here's a final version of gdbserver support for Windows DLLs.
> > It works for me testing with Cygwin.  Pedro, would you like to test
> > this on Windows CE to see what I've broken?
>
> It looks alright, except that gdb/config/arm/wince.mt and 
> gdb/arm-wince-tdep.c
> (to add solib-target.c, and remove the svr4 copy/paste thinko) hunks
> got left out.

Testing on Windows CE didn't show up any new problems.

Attached are the patches to use solib-target.c on WinCE, and a small fix to
gdbserver/win32-low.c to get toolhelp from toolhelp.dll instead
of coredll.dll - not your fault, the version I sent you had it wrong.

I had a problem building solib-target.c that I'm reporting in
another thread.

gdb/
	* arm-wince-tdep.c (arm_wince_init_abi): Remove svr4 related calls.
	* config/arm/wince.mt (TDEPFILES): Remove solib-legacy.o and
	solib-svr4.o, and add solib-target.o

gdb/gdbserver/
	* win32-low.c (load_toolhelp) [_WIN32_WCE]: Load functions from
	TOOLHELP.DLL.

--
Cheers,
Pedro Alves


	* arm-wince-tdep.c (arm_wince_init_abi): Remove svr4 related calls.
	* config/arm/wince.mt (TDEPFILES): Remove solib-legacy.o and
	solib-svr4.o, and add solib-target.o

---
 gdb/arm-wince-tdep.c    |    3 ---
 gdb/config/arm/wince.mt |    2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

Index: src/gdb/arm-wince-tdep.c
===================================================================
--- src.orig/gdb/arm-wince-tdep.c	2007-07-03 20:49:54.000000000 +0100
+++ src/gdb/arm-wince-tdep.c	2007-07-04 00:56:52.000000000 +0100
@@ -55,9 +55,6 @@ arm_wince_init_abi (struct gdbarch_info 
   /* On ARM WinCE char defaults to signed.  */
   set_gdbarch_char_signed (gdbarch, 1);
 
-  set_solib_svr4_fetch_link_map_offsets
-    (gdbarch, svr4_ilp32_fetch_link_map_offsets);
-
   /* Shared library handling.  */
   set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
 
Index: src/gdb/config/arm/wince.mt
===================================================================
--- src.orig/gdb/config/arm/wince.mt	2007-07-03 20:49:54.000000000 +0100
+++ src/gdb/config/arm/wince.mt	2007-07-04 00:55:54.000000000 +0100
@@ -1,4 +1,4 @@
 # Target: ARM based machine running Windows CE (win32)
 DEPRECATED_TM_FILE= tm-arm.h
 TDEPFILES= arm-tdep.o arm-wince-tdep.o corelow.o \
-  solib.o solib-legacy.o solib-svr4.o
+  solib.o solib-target.o


	* win32-low.c (load_toolhelp) [_WIN32_WCE]: Load functions from
	TOOLHELP.DLL.

---
 gdb/gdbserver/win32-low.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/win32-low.c
===================================================================
--- src.orig/gdb/gdbserver/win32-low.c	2007-07-08 00:49:34.000000000 +0100
+++ src/gdb/gdbserver/win32-low.c	2007-07-08 00:52:44.000000000 +0100
@@ -985,7 +985,7 @@ load_toolhelp (void)
 #ifndef _WIN32_WCE
       dll = GetModuleHandle (_T("KERNEL32.DLL"));
 #else
-      dll = GetModuleHandle (_T("COREDLL.DLL"));
+      dll = LoadLibrary (_T("TOOLHELP.DLL"));
 #endif
       if (!dll)
 	return FALSE;