This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: FW: [PATCH] jv-lang, guard against NULL

From: Daniel Jacobowitz <drow at false dot org>
To: msnyder at sonic dot net
Cc: gdb-patches at sourceware dot org
Date: Thu, 2 Aug 2007 17:37:24 -0400
Subject: Re: FW: [PATCH] jv-lang, guard against NULL
References: <12757.12.7.175.2.1185924312.squirrel@webmail.sonic.net> <20070802210606.GF6563@caradoc.them.org> <655C3D4066B7954481633935A40BB36F22BA4C@ussunex02.svl.access-company.com> <12786.12.7.175.2.1186090201.squirrel@webmail.sonic.net>

On Thu, Aug 02, 2007 at 02:30:01PM -0700, Michael Snyder wrote:
> Good idea -- except, can we really be sure that name can
> never legitimately be null?  Oh, yeah, I guess the unprotected
> strrchr sort of tells us that, doesn't it?
> 
> OK, how about this?

I've no complaint.  I don't think this sort of assert adds much value,
though.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- Re: [PATCH] jv-lang, guard against NULL
  - From: Daniel Jacobowitz
- Re: FW: [PATCH] jv-lang, guard against NULL
  - From: msnyder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]