This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] symfile.c, find_separate_debug_file
On Fri, Aug 03, 2007 at 07:37:35AM -0700, Michael Snyder wrote:
> Yes, I understood exactly what Daniel meant. I was saying,
> the existing code uses the literal '/' instead of the symbolic
> DIR_SEPARATOR.
>
> I offered to have another go at the code and clean up the literals,
> but as a separate patch to this one.
You added two lines:
! if (debugfile[strlen (debugfile) - 1] != '/' && dir[0] != '/')
! strcat (debugfile, "/");
I think you're talking about the second one, which adds a "/". That's
fine, but the first line isn't. Other places in that function which
compare against '/' use IS_DIR_SEPARATOR already.
--
Daniel Jacobowitz
CodeSourcery