This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] dwarf2read.c, memory leak

From: Jim Blandy <jimb at codesourcery dot com>
To: msnyder at sonic dot net
Cc: gdb-patches at sourceware dot org
Date: Mon, 06 Aug 2007 15:03:47 -0700
Subject: Re: [PATCH] dwarf2read.c, memory leak
References: <20951.12.7.175.2.1186279295.squirrel@webmail.sonic.net>

msnyder@sonic.net writes:
> 2007-08-04  Michael Snyder  <msnyder@access-company.com>
>
> 	* dwarf2read.c (add_partial_symbol): Memory leak.

This looks fine.

As a matter of taste, is it better to duplicate the 'if
(built_actual_name) xfree (actual_name)' three times or to use 'goto'?

Follow-Ups:
- Re: [PATCH] dwarf2read.c, memory leak
  - From: msnyder

References:
- [PATCH] dwarf2read.c, memory leak
  - From: msnyder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]