This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [OB] tui, coding standard


msnyder@sonic.net writes:
>>> Date: Tue, 14 Aug 2007 17:18:45 -0700 (PDT)
>>> From: msnyder@sonic.net
>>>
>>> && and || operators.
>>
>> This diff wraps some lines that fit perfectly well on a single line; I
>> think you shouldn't do that.  Otherwise, this looks ok.
>
> OK, maybe I was a little gung ho.  Do you have an idea,
> for yourself, of what constitutes a line that is too long?

You didn't ask me, :) but my rule is that a &&-chain or a ||-chain
should either fit entirely on one line, or have one condition per
line.  Either horizontal or vertical, but not a mix.

I sure wouldn't want to require every && or || to be on its own line,
but I don't like to read mixes, ergo...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]