This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] strlen(null) in dwarf2read
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: msnyder at sonic dot net
- Cc: brobecker at adacore dot com, msnyder at sonic dot net, gdb-patches at sourceware dot org
- Date: Wed, 5 Sep 2007 09:25:58 +0200 (CEST)
- Subject: Re: [patch] strlen(null) in dwarf2read
- References: <15003.12.7.175.2.1188424188.squirrel@webmail.sonic.net> <20070904142440.GD3579@adacore.com> <4144.12.7.175.2.1188951036.squirrel@webmail.sonic.net>
> Date: Tue, 4 Sep 2007 17:10:36 -0700 (PDT)
> From: msnyder@sonic.net
>
> >> 2007-08-29 Michael Snyder <msnyder@access-company.com>
> >>
> >> * dwarf2read.c (determine_prefix): Do not send NULL to strlen.
> >
> > Proofread, and no comment :)
> >
> > (actually, yes: I'm much better at reading unified diff, not sure
> > about others - I ended up applying your patch locally and regenerating
> > the diff)
>
> All right. The reason I like -p is because it gives me the
> function name for context. I can see that -u is more concise.
>
> Wonder if there is a way to get the best of both?
-up works like a charm ;)