This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][Patch RFC] ARI changes for p-valprint.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 7 Sep 2007 07:58:45 -0400
- Subject: Re: [PING][Patch RFC] ARI changes for p-valprint.c
- References: <001601c7f137$937f3070$ba7d9150$@u-strasbg.fr>
On Fri, Sep 07, 2007 at 12:12:20PM +0200, Pierre Muller wrote:
> I could commit these as pascal maintainer, but I would like to have
> feedback,
> especially about how to phrase the ChangeLog entry, I put a minimal here,
> but would like to know if more details are needed.
Yes, more details are needed. It should have a function-level
description of changes, except when you're making huge mechanical
changes.
> - deprecated_print_address_numeric (addr, 1, stream);
> + fputs_filtered (paddress(addr), stream);
Space before parentheses, please.
> @@ -217,7 +217,7 @@ pascal_val_print (struct type *type, con
> int is_this_fld;
>
> if (msymbol != NULL)
> - wsym = lookup_symbol (DEPRECATED_SYMBOL_NAME (msymbol),
> block,
> + wsym = lookup_symbol ((msymbol)->ginfo.name, block,
> VAR_DOMAIN, &is_this_fld, NULL);
>
> if (wsym)
No, please don't use the members directly. Replace this with one of
the other SYMBOL_*_NAME macros. Originally, this used to be
SYMBOL_NAME; then the others were introduced, and this one was
deprecated because it did not make clear what sort of name was
wanted. Since it is being passed to lookup_symbol,
SYMBOL_LINKAGE_NAME is probably best.
> + fputs_filtered (paddress(
Space again.
Looks fine otherwise. Sorry for not getting to it before.
--
Daniel Jacobowitz
CodeSourcery