This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: mips-tdep.c: Fix a comment about new-ABI FP return values
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: gdb-patches at sourceware dot org
- Cc: David Ung <davidu at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Tue, 25 Sep 2007 17:03:10 +0100 (BST)
- Subject: Re: mips-tdep.c: Fix a comment about new-ABI FP return values
Hello,
The comment about single/double FP return values in
mips_n32n64_return_value() is obviously incorrect. There is no such thing
as the least significant part of FP0. [OK, the cp0.Status.FR bit lets you
truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the
new ABI assumes this compatibility mode is not used.]
2007-09-25 David Ung <davidu@mips.com>
Maciej W. Rozycki <macro@mips.com>
* mips-tdep.c (mips_n32n64_return_value): Fix a comment.
OK to apply?
Maciej
12695.diff
Index: binutils-quilt/src/gdb/mips-tdep.c
===================================================================
--- binutils-quilt.orig/src/gdb/mips-tdep.c 2007-09-25 16:29:10.000000000 +0100
+++ binutils-quilt/src/gdb/mips-tdep.c 2007-09-25 16:30:32.000000000 +0100
@@ -3127,8 +3127,7 @@
else if (TYPE_CODE (type) == TYPE_CODE_FLT
&& tdep->mips_fpu_type != MIPS_FPU_NONE)
{
- /* A floating-point value belongs in the least significant part
- of FP0. */
+ /* A single or double floating-point value that fits in FP0. */
if (mips_debug)
fprintf_unfiltered (gdb_stderr, "Return float in $fp0\n");
mips_xfer_register (regcache,