This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Avoid builtin_type_int during type construction
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: drow at false dot org
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 3 Oct 2007 23:12:11 +0200 (CEST)
- Subject: Re: [commit] Avoid builtin_type_int during type construction
- References: <20071003204110.GA29601@caradoc.them.org>
> Date: Wed, 3 Oct 2007 16:41:10 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> I wanted to construct a new type during gdbarch initialization and
> ran into two problems caused by the use of builtin_type_int, which
> is now a macro referencing current_gdbarch.
>
> Every range type created uses builtin_type_int as the type of its
> fields (which hold the range's endpoints). There's an unclear
> FIXME here. The use of int isn't necessary; nothing ever looks at the
> types of these fields, and the comments in gdbtypes.h suggest that
> their types are unused.
>
> And every vector type is an array using int as its index type. Since
> vectors are small arrays of constant size, there's no worry about this
> type; int32 works just as well.
>
> Tested on x86_64-linux and committed.
>
> --
> Daniel Jacobowitz
> CodeSourcery
>
> 2007-10-03 Daniel Jacobowitz <dan@codesourcery.com>
>
> * gdbtypes.c (create_range_type): Do not set TYPE_FIELD_TYPE for the
> bounds.
> (init_vector_type): Use builtin_type_int32.
This must be wrong somehow; int isn't necessarily a 32-bit type.
> Index: gdbtypes.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtypes.c,v
> retrieving revision 1.134
> diff -u -p -r1.134 gdbtypes.c
> --- gdbtypes.c 5 Sep 2007 00:51:48 -0000 1.134
> +++ gdbtypes.c 3 Oct 2007 20:36:41 -0000
> @@ -705,8 +705,6 @@ create_range_type (struct type *result_t
> memset (TYPE_FIELDS (result_type), 0, 2 * sizeof (struct field));
> TYPE_FIELD_BITPOS (result_type, 0) = low_bound;
> TYPE_FIELD_BITPOS (result_type, 1) = high_bound;
> - TYPE_FIELD_TYPE (result_type, 0) = builtin_type_int; /* FIXME */
> - TYPE_FIELD_TYPE (result_type, 1) = builtin_type_int; /* FIXME */
>
> if (low_bound >= 0)
> TYPE_FLAGS (result_type) |= TYPE_FLAG_UNSIGNED;
> @@ -950,7 +948,7 @@ init_vector_type (struct type *elt_type,
>
> array_type = create_array_type (0, elt_type,
> create_range_type (0,
> - builtin_type_int,
> + builtin_type_int32,
> 0, n-1));
> make_vector_type (array_type);
> return array_type;
>