This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c


> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 8 Oct 2007 16:12:45 +0200
> 
>   The include ordering stuff seems completely
> opaque to me anyhow.
>   <ctype.h> is included as last in linux-fork.c,
> but right after "defs.h" in breakpoint.c.
> Is there any rational for this?

Other than that people have been sloppy in the past?  No I don't think
so.

>   Anyhow, if you also agree, it is probably best to leave 
> the ordering exactly as it was, just to stay on the 
> safe side.
> 
>   Should I move the gdb_wait.h include back to where wait.h was?

I'd prefer that; consider a patch that does that pre-approved.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]