This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c
- From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- To: "'Markus Deuling'" <deuling at de dot ibm dot com>, "'GDB Patches'" <gdb-patches at sourceware dot org>
- Cc: "'Ulrich Weigand'" <uweigand at de dot ibm dot com>
- Date: Thu, 11 Oct 2007 12:35:09 +0200
- Subject: RE: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c
- References: <470DE4AC.2020101@de.ibm.com>
The patch seems OK, but
I compiled it by applying also the objfiles.c patch
and tried to get the pascal_create_fundamental_type to
be called, and had a hard time finding something
that triggered a call to that function.
I finally found that an untyped real constant in pascal
with stabs debugging worked, and the code seemed to be working
fine.
Thus the pascal patch is approved.
Just a small remark on your ChangeLog:
you forgot the 's' on objfiles.h for the Makefile.in entry.
Pierre Muller
Pascal language maintainer.
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Markus Deuling
> Sent: Thursday, October 11, 2007 10:54 AM
> To: GDB Patches
> Cc: Ulrich Weigand
> Subject: [rfc] [10/17] Get rid of current_gdbarch in p-lang.c
>
> Hi,
>
> this patch gets rid of some of the current_gdbarch's in p-lang.c Is
> this ok to commit?
>
> ChangeLog:
>
>
> * p-lang.c: Add new include objfiles.h.
> (pascal_create_fundamental_type): Use objfile->gdbarch to get
> at the current architecture.
> * Makefile.in (p-lang.o): Add dependency on objfile.h.
>
>
>
> --
> Markus Deuling
> GNU Toolchain for Linux on Cell BE
> deuling@de.ibm.com
>
>
>