This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RFA: make subfiles static
- From: "Douglas Evans" <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 14 Nov 2007 19:34:53 -0800
- Subject: RFA: make subfiles static
Any reason not to make subfiles local to buildsym.c?
ok to check in?
2007-11-14 Doug Evans <dje@google.com>
* buildsym.h (subfiles): Move ...
* buildsym.c (subfiles): ... to here and make static.
Index: buildsym.h
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.h,v
retrieving revision 1.17
diff -u -p -r1.17 buildsym.h
--- buildsym.h 23 Aug 2007 18:08:26 -0000 1.17
+++ buildsym.h 15 Nov 2007 03:30:20 -0000
@@ -71,8 +71,6 @@ struct subfile
struct symtab *symtab;
};
-EXTERN struct subfile *subfiles;
-
EXTERN struct subfile *current_subfile;
/* Global variable which, when set, indicates that we are processing a
Index: buildsym.c
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.c,v
retrieving revision 1.56
diff -u -p -r1.56 buildsym.c
--- buildsym.c 14 Nov 2007 23:14:40 -0000 1.56
+++ buildsym.c 15 Nov 2007 03:30:20 -0000
@@ -55,6 +55,10 @@
#include "stabsread.h"
+/* List of subfiles. */
+
+static struct subfile *subfiles;
+
/* List of free `struct pending' structures for reuse. */
static struct pending *free_pendings;