This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: delete_breakpoint: don't try to insert other breakpoints
On Friday 16 November 2007 13:13:24 Eli Zaretskii wrote:
> > From: Vladimir Prus <ghost@cs.msu.su>
> > Date: Thu, 15 Nov 2007 08:59:19 +0300
> >
> > > I think you are assuming that this code does and will always run
> > > synchronously. Is that a valid assumption?
> >
> > At the moment, I'm not aware of any way to invoke delete_breakpoint
> > while existing breakpoints are inserted. Is there one?
> > (In particular, "target async" does not seem to work at all).
> >
> > In future, this situation might be possible. However, in general
> > I think it's better to start by making code clear while still
> > working for current GDB, and then adjust it as needed for future GDB.
> > In this particular case, a call to insert_breakpoints, together
> > with some adjustments, would be much better for any future async code,
> > as it won't duplicate code logic.
>
> I'm okay with making the code cleaner, but on at a price of removing
> features, even if they are currently unused.
Let me clarify -- I'm not aware of *any* way that this code can affect anything
in the current GDB, it's not excercised by any tests, and therefore is essentially
a dead code. Therefore, I don't think it's fair to say this code is a "feature".
Removing it will simplify current code, and the removed part will still be in CVS,
so should we ever need to consult it, it's quite possible. Why keep unused code
in HEAD?
- Volodya