This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: delete_breakpoint: don't try to insert other breakpoints
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 16 Dec 2007 15:59:39 -0500
- Subject: Re: delete_breakpoint: don't try to insert other breakpoints
- References: <200711142324.11319.vladimir@codesourcery.com>
On Wed, Nov 14, 2007 at 11:24:10PM +0300, Vladimir Prus wrote:
>
> The delete_breakpoint function tries to check if the
> breakpoint being deleted is inserted in inferior, and if
> so, searched for breakpoints that are set at the same address
> and tries to insert them. However, GDB removes breakpoint
> from the inferior immediately when inferior is stopped,
> so this code will never run. Removing this code has
> no effect on test results.
>
> (And generally, if that function needed to insert breakpoints,
> it should have used insert_breakpoints, instead of duplicating
> the logic somewhat).
>
> OK?
I believe that another version of this patch, which replaces the wrong
code with more useful behavior, is part of your keep breakpoints
inserted RFC, so this patch is withdrawn. Let me know if I'm
wrong :-)
--
Daniel Jacobowitz
CodeSourcery