This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Make DWARF-2 "address size" explicit


Daniel Jacobowitz <drow at false.org> writes:
> On Sun, Dec 09, 2007 at 08:39:55PM +0100, Ulrich Weigand wrote:
>> This patch changes this by making the parameter explicit as member
>> of the dwarf_expr_context structure.  The core DWARF expresssion
>> engine thus no longer needs to make this assumption.
>
> Seems right to me!

This is certainly a step in the right direction.  However, the proper
value to use for addr_size is the one that comes from the header of
the compilation unit containing the expression.  (The fact that
there's no compilation unit associated with the frame information is
an existing problem.)

I had a patch to carry that through from a long while back.  A fellow
from Intel has been working on updating it; I've encouraged him to
post it here.

http://sourceware.org/ml/gdb-patches/2006-05/msg00226.html


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]