This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] TUI do not display current execution point
- From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- To: "'Denis PILAT'" <denis dot pilat at st dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 19 Dec 2007 14:56:18 +0100
- Subject: RE: [RFA] TUI do not display current execution point
- References: <47691CE9.9020302@st.com>
Code in gdb directory (utils.c and top.c)
using PATH_MAX first check if that macro is defined.
Shouldn't you do the same in that patch?
Pierre Muller
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Denis PILAT
> Sent: Wednesday, December 19, 2007 2:30 PM
> To: gdb-patches
> Subject: [RFA] TUI do not display current execution point
>
> For binary files that have been compiled using a long absolute path,
> the old constant
> MAX_LOCATOR_ELEMENT_LEN is not long enough.
>
> tui_source_is_displayed() called from "tui-
> stack.c/tui_show_frame_info()"
> always returns false and we never execute "tui_set_is_exec_point_at ()"
> function.
>
> The side effect is that the ">" character is never displayed in the
> left pane of the TUI window.
>
> The problem was not easy to find, but the bellow patch is very simple
> and fix it.
>
> OK for commit ?
>
> --
>
> Denis
>
> --- ../../../../../vendor/GDB6.7.1/gdb/tui/tui-data.h 2007-12-12
> 18:05:18.000000000 +0100
> +++ ./tui-data.h 2007-12-19 14:03:59.000000000 +0100
> @@ -196,7 +196,7 @@ struct tui_command_element
> };
>
>
> -#define MAX_LOCATOR_ELEMENT_LEN 100
> +#define MAX_LOCATOR_ELEMENT_LEN PATH_MAX
>
> /* Elements in the locator window content. */
> struct tui_locator_element
>
>