Re: [commit/Ada] Attach ada_executable_changed_observer

[Joel Brobecker <brobecker at adacore dot com>]

> We deliberately do not use -Wunused or any of the more specific unused
> warnings.  I think we should use them and mark unused
> parameters to functions with ATTRIBUTE_UNUSED, or else use them except
> for the unused parameter warnings; turning it on would take someone
> motivated to clean up all the resulting -Werror build failures.

Ah ha, I see. I was so convinced that -Wunused was used that I didn't
even look at the list of options used to compiler. Duh! and thanks!

I have added the following item in the "Internals" section of
ProjectIdeas in the wiki:

    Enable building with -Wunused. Right now, this option is not enabled
    because the current sources would need to be cleaned up a bit. In
    particular, there are probably some unused entities left, as well as
    some function parameters that are unused. Enabling this option would
    require someone motivated to fix all the warnings that it would
    generate. Alternatively, we could use -Wunused minus the unused
    parameter warnings, which would already be a nice improvement but at
    a more reduced cleanup cost.

I may pick that action item up, one day.

-- 
Joel