[rfc] [2/2] Remove macros TARGET_{FLOAT,DOUBLE,LONG_DOUBLE}_{BIT|FORMAT}
Markus Deuling
deuling@de.ibm.com
Tue Jun 12 14:47:00 GMT 2007
Hallo Ulrich,
thank you for your review again.
Ulrich Weigand wrote:
>
>
> /* NOTE: The new architecture variable is named ``current_gdbarch''
> - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to
> + so that macros such as gdbarch_double_bit, when expanded, refer to
> the current local architecture and not the previous global
> architecture. This ensures that the new architectures initial
> values are not influenced by the previous architecture. Once
>
> Well, replacing the macro by a gdbarch function invalidates the whole point
> the comment is making ;-) You should either use another macro (that still
> is a macro) as example, or -once there are no macros left- remove that
> comment.
>
>
You're right :-) I took TARGET_ARCHITECTURE for now. I'll remove the comment when finishing the macro transition.
Attached is a reworked patch.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff-remove-FLOAT
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070612/7aa11d90/attachment.ksh>
More information about the Gdb-patches
mailing list