This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/DWARF] Set TYPE_FLAG_STUB for enum DIEs that are declarations only

> Date: Sat, 5 Jan 2008 07:05:14 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> TYPE_FLAG_STUB and a non-zero DW_AT_declaration attribute are two
> ways of saying the same thing.

And this is supposed to be known to Joe Random Hacker reading the code
because ...?  Should we assume that whoever reads dwarf2read.c is
necessarily a DWARF-2 expert?

> Are you sure you want a comment?
> 
>   /* If the type is a declaration, then the definition is not
>      complete.  Mark the type as a stub.  */
> 
> This comment is just repeating the code.

That's not the kind of comment I was suggesting.  I meant some summary
of the long explanation you posted as a preamble to the patch, which
explained why debugging Ada programs needed that.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]