This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] win32-nat.c: Improve handling of 'set shell on'
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Pierre Muller <muller at ics dot u-strasbg dot fr>, gdb-patches at sourceware dot org
- Date: Wed, 9 Jan 2008 12:03:34 -0800
- Subject: Re: [RFC] win32-nat.c: Improve handling of 'set shell on'
- References: <000001c8529e$a8088460$f8198d20$@u-strasbg.fr> <utzlmsubo.fsf@gnu.org>
> > I ran the testsuite with a single line
> > modified:
> > -static int useshell = 0; /* use shell for subprocesses */
> > +static int useshell = 1; /* use shell for subprocesses */
> > Which made the use of shell to start the subprocess
> > the default.
>
> Is this really appropriate for the native Windows port of GDB as well
> as for Cygwin? If not, we should set this only conditionally, I
> think.
I understood that this part of the patch was NOT to be committed
(from a // comment in the ChangeLog IIRC). After having explained
how the patch was tested, I would have excluded that hunk from
the patch, IMO.
--
Joel