This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Remove all current_gdbarch's in mn10300
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Tue, 15 Jan 2008 21:38:29 +0100 (CET)
- Subject: Re: [patch] Remove all current_gdbarch's in mn10300
Markus Deuling wrote:
> * mn10300-tdep.h (AM33_MODE): Add gdbarch as parameter.
> * mn10300-tdep.c (set_reg_offsets, mn10300_analyze_prologue): Use
> get_frame_arch to get at the current_architecture. Update AM33_MODE
> call.
> (mn10300_analyze_prologue): Add gdbarch as parameter. Update caller.
> (mn10300_frame_unwind_cache): Use get_frame_arch to get at the current
> architecture.
> (set_reg_offsets, mn10300_analyze_prologue): Fix indentation.
This is OK, but please fix this small whitespace issue:
> + if (AM33_MODE (gdbarch)== 2)
Space between ')' and '=='.
> + if (AM33_MODE (gdbarch)== 2)
Likewise.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com