This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BUG:MI] -break-list doesn't list multiple breakpoints


 > > Here's a patch that fixes this but does much more.  The 'fix' works by
 > > removing the frame details in the MI output:
 > > 
 > > (gdb) 
 > > -break-insert 10
 > > ^done
 > 
 > Which is a backwards incompatible change, and other frontends use this
 > information; we can't remove it.

It's a backwards incompatible change but do other frontends use it?  In
principle you're right, of course, we can't remove it.  In practice, however,
some of the initial design was arbitrary and not born out of experience and
this is a public list where frontend developers can participate and have been
encouraged to do do.  They have an opportunity to object and such changes
might accelerate progress.

 > > this means that the condition:
 > > 
 > > 	  && !ui_out_is_mi_like_p (uiout))
 > > 
 > > can be removed from print_one_breakpoint so that -break-list prints
 > > details of all the multiple breakpoint locations.
 > 
 > I don't understand; how does this follow from the other change?

This code is executed by both -break-list and -break-insert.  By contrast,
ISTR that in CLI, it is executed by "info break" but not break.

As an alternative, I guess this line alone could be removed so that
-break-insert lists the multiple breakpoint locations being set and the
adjust MI documentation to explain this.

In any case, I think deprecated_set_gdb_event_hooks should go.  In CLI,
breakpoint details are printed in mention with say_where=1.  I don't really
understand why things need to differently for MI or why it can't be done
here too.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]