RE: [Patch] -var-evaluate-expression NAME [FORMAT]

["Marc Khouzam" <marc dot khouzam at ericsson dot com>]

> I honestly don't like this 'set global format, then cleanup'
> trick, but that's something we can fix later.

There was another suggested solution in:
http://sourceware.org/ml/gdb-patches/2008-01/msg00531.html
But it seemed like too much impact.

> > -          else  if (var->value == NULL && value == NULL)
> > +         else  if (var->value == NULL && value == NULL)
> 
> Did you do something about indentation here?

I went through the file and replaced any starting sequence of
8 spaces with a tab.  I hesitated at changing parts of the file
I didn't actually change, but since they were minor changes,
I though it would make the file more readable.

[...]
> > if (mi_version (uiout) > 1)
> > -        do_cleanups (cleanup);
> > +       do_cleanups (cleanup);
> 
> Lots of reformatting here as well. The patch looks otherwise
> good to me.

All these reformats are replacing 8 spaces with tabs.

Unless you guys want me to revert that extra reformatting, 
I guess the patch is good?  
Who's gonna apply it? :-)

Thanks

Marc