This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: remote-mips.c: Fix namespace pollution
- From: Daniel Jacobowitz <drow at false dot org>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: gdb-patches at sourceware dot org, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Tue, 5 Feb 2008 13:07:40 -0500
- Subject: Re: remote-mips.c: Fix namespace pollution
- References: <Pine.LNX.4.61.0802051741330.28589@perivale.mips.com>
On Tue, Feb 05, 2008 at 05:49:44PM +0000, Maciej W. Rozycki wrote:
> Hello,
>
> The recent renaming of gdb_breakpoint() to set_breakpoint() within
> breakpoint.c triggered a problem with remote-mips.c defining a static
> function of the same name. Given breakpoint.c is a piece of generic code
> I think it is the responsibility of the target-specific bits to keep the
> namespace clean. Taking this into account I have prepared the following
> change which renames all the related functions, giving them a mips_
> prefix.
>
> 2008-02-05 Maciej W. Rozycki <macro@mips.com>
>
> * remote-mips.c (set_breakpoint): Rename to...
> (mips_set_breakpoint): ... this.
> (clear_breakpoint): Rename to...
> (mips_clear_breakpoint): ... this.
> (common_breakpoint): Rename to...
> (mips_common_breakpoint): ... this.
> (check_lsi_error): Rename to...
> (mips_check_lsi_error): ... this.
>
> OK to apply?
OK, thanks.
--
Daniel Jacobowitz
CodeSourcery