This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Implement -thread-info.
On Wednesday 20 February 2008 22:37:25 Nick Roberts wrote:
> > > Also do you want to
> > > catch errors in print_stack_frame?
> >
> > Yes, why not? A typical error is when we have a char* parameter pointing to
> > something not very accessible, in which case I'd prefer print_stack_frame
> > to catch this error, as opposed to -thread-info outright dying.
>
> If there is an error then presumably you want MI to catch (and report) it.
> I don't know if this is a problem, in practice, because I don't know how to
> get print_stack_frame to fail.
Well, the only error I know is failure to access memory when printing
arguments, which I probably don't want to convert into ^error of the entire
command. Should we run into really fatal errors that should terminate
-thread-info, we can always change.
>
> > > > I don't know what problem of return type you refer to -- can you
> > > > clarify?
> > >
> > > That, in Denis' patch, gdb_thread_info returns type enum gdb_rc but
> > > catch_exceptions_with_msg returns type int. (just like gdb_breakpoint and
> > > break_command_really did for a while).
> >
> > This problem does not exist in my patch, as catch_exceptions_with_msg is
> > just not used.
>
> You misunderstand. The problem you were asking about was in Denis' patch.
> I never said it was in yours.
OK.
- Volodya