This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa/solib] Always reload DT_DEBUG, trust r_brk
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 20 Feb 2008 17:08:44 -0700
- Subject: Re: [rfa/solib] Always reload DT_DEBUG, trust r_brk
- References: <20080208191111.GA30569@caradoc.them.org>
> 2008-02-08 Daniel Jacobowitz <dan@codesourcery.com>
>
> * mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Set
> r_brk_offset.
> (mipsnbsd_lp64_fetch_link_map_offsets): Likewise.
> * solib-svr4.c (solib_svr4_r_brk): New.
> (open_symbol_file_object, svr4_current_sos): Always check the
> debug base.
> (svr4_fetch_objfile_link_map): Do not set debug_base.
> (enable_break): Use r_brk if it is set.
> (svr4_ilp32_fetch_link_map_offsets): Set r_brk_offset.
> (svr4_lp64_fetch_link_map_offsets): Likewise.
> * solib-svr4.h (struct link_map_offsets): Add r_brk_offset.
These changes look reasonable to me. Go ahead and commit them.
Kevin